Fe fix phone number validation - #1847
Merged
Merged
Conversation
ThomasNickerson
requested review from
FestiveKyle,
lcampbell2,
nsdeschenes and
tparrott-cse
March 11, 2021 17:15
nsdeschenes
suggested changes
Mar 12, 2021
nsdeschenes
left a comment
nsdeschenes
left a comment
Contributor
There was a problem hiding this comment.
You're missing the compiled locale files all you gotta do is run npm run compile and add them to git, and we'll be good to go!
FestiveKyle
approved these changes
Mar 12, 2021
nsdeschenes
approved these changes
Mar 15, 2021
tparrott-cse
approved these changes
Mar 15, 2021
tparrott-cse
left a comment
tparrott-cse
left a comment
Contributor
There was a problem hiding this comment.
Approved pending resolution of Nick's comment
lcampbell2
approved these changes
Mar 15, 2021
Contributor
Author
Compiled locale files were added in 7f824ec which should resolve that issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1685 by adding validation of phone numbers with regex on the front end according to the format specified in API docs.